Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Error getting VM/Host IP address on clean install #8083

Closed
wants to merge 2 commits into from
Closed

fix Error getting VM/Host IP address on clean install #8083

wants to merge 2 commits into from

Conversation

szabolcsdombi
Copy link
Contributor

  • replace getIPForInterface with VBoxManage equivalent
  • network created by VirtualBox 6.1.6 is named differently then the adapter on Windows 10
  • minikube v1.10.0 was failing to start due to net.InterfaceByName is failing inside getIPForInterface

Reproduce the error:

On a clean Windows 10 install with VirtualBox 6.1.6 the Host only adapter name is not matching the network name so net.InterfaceByName will fail due to the passed name is not an interface name.

Error screenshot on clean start

Screenshot_7

@szabolcsdombi
fix Error getting VM/Host IP on clean install
9bd3aab 
- replace getIPForInterface with VBoxManage equivalent
- network created by VirtualBox 6.1.6 is named differently then the adapter on Windows 10
- minikube v1.10.0 was failing to start due to net.InterfaceByName is failing inside getIPForInterface
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 12, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @cprogrammer1994!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 12, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @cprogrammer1994. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cprogrammer1994
To complete the pull request process, please assign ra489
You can assign the PR to them by writing /assign @ra489 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@szabolcsdombi
Copy link
Contributor Author

Temporary workaround:

go to the View Network Connections

rename
VirtualBox Host-Only Network #2
to
VirtualBox Host-Only Ethernet Adapter #2

if rename does not help take the name of the hostonlyadapter2 from the following command:

VboxManage.exe showvminfo minikube --machinereadable

...
hostonlyadapter2="VirtualBox Host-Only Ethernet Adapter #2"
...

@medyagh
Copy link
Member

medyagh commented May 12, 2020

@cprogrammer1994 thanks for bringing this to our attention, please make sure to sign the CLA. so we could accept this PR.

and also do you mind sharing the output After this PR to see if that is fixed?

This was referenced May 12, 2020
Closed
Closed
Closed
@sharifelgamal sharifelgamal mentioned this pull request May 12, 2020
Merged
@medyagh medyagh mentioned this pull request May 12, 2020
Closed
@medyagh
Copy link
Member

medyagh commented May 13, 2020 •
edited
Loading

@cprogrammer1994 thank you very very much for fixing this, unforuantely we had to push an emergency release quickly and couldn't merge your PR but we thanked you in our release notes.

we hope to see more contributions from you, thank you for the good quality work !

https://github.com/kubernetes/minikube/releases/tag/v1.10.1

@k8s-ci-robot
Copy link
Contributor

@cprogrammer1994: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2020
@medyagh medyagh closed this May 13, 2020
@szabolcsdombi
Copy link
Contributor Author

@medyagh thank you for the quick resolution.
Due to my timezone I was not able to respond to your message in time.
It is great the fix did not have to wait.
Also great to hear v1.10.1 is out.

I will try v1.10.1 within a clean environment and get back with the results.

Thank you for this great project!

@szabolcsdombi
Copy link
Contributor Author

and also do you mind sharing the output After this PR to see if that is fixed?

Screenshot_8

works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@medyagh medyagh Awaiting requested review from medyagh

Assignees
No one assigned
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@szabolcsdombi @k8s-ci-robot @minikube-bot @medyagh